sam/sfizz
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Set loop_mode to one_shot for release regions

Browse source
This commit is contained in:
Paul Ferrand 2020-08-18 23:13:11 +02:00
parent 95165ca650
commit 1cf5e8d571
2 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/sfizz/Region.cpp
View file

@ -349,9 +349,11 @@ bool sfz::Region::parseOpcode(const Opcode& rawOpcode)
break; break;
case hash("release"): case hash("release"):
trigger = SfzTrigger::release; trigger = SfzTrigger::release;
loopMode = SfzLoopMode::one_shot;
break; break;
case hash("release_key"): case hash("release_key"):
trigger = SfzTrigger::release_key; trigger = SfzTrigger::release_key;
loopMode = SfzLoopMode::one_shot;
break; break;
default: default:
DBG("Unknown trigger mode: " << opcode.value); DBG("Unknown trigger mode: " << opcode.value);

5
tests/RegionT.cpp
View file

@ -497,10 +497,15 @@ TEST_CASE("[Region] Parsing opcodes")
REQUIRE(region.trigger == SfzTrigger::attack); REQUIRE(region.trigger == SfzTrigger::attack);
region.parseOpcode({ "trigger", "release" }); region.parseOpcode({ "trigger", "release" });
REQUIRE(region.trigger == SfzTrigger::release); REQUIRE(region.trigger == SfzTrigger::release);
REQUIRE(region.loopMode == SfzLoopMode::one_shot);
region.parseOpcode({ "trigger", "first" }); region.parseOpcode({ "trigger", "first" });
REQUIRE(region.trigger == SfzTrigger::first); REQUIRE(region.trigger == SfzTrigger::first);
region.parseOpcode({ "trigger", "legato" }); region.parseOpcode({ "trigger", "legato" });
REQUIRE(region.trigger == SfzTrigger::legato); REQUIRE(region.trigger == SfzTrigger::legato);
region.parseOpcode({ "loop_mode", "no_loop" });
region.parseOpcode({ "trigger", "release_key" });
REQUIRE(region.trigger == SfzTrigger::release_key);
REQUIRE(region.loopMode == SfzLoopMode::one_shot);
} }
SECTION("on_locc, on_hicc") SECTION("on_locc, on_hicc")