From 1f91bf0f66d29891bf51f756488b5aa4b08af94a Mon Sep 17 00:00:00 2001 From: Jean Pierre Cimalando Date: Fri, 6 Mar 2020 23:43:30 +0100 Subject: [PATCH] Fix a potential null pointer error (effect buses can have gaps) --- src/sfizz/Synth.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/sfizz/Synth.cpp b/src/sfizz/Synth.cpp index 67dadef1..0ffcfdb8 100644 --- a/src/sfizz/Synth.cpp +++ b/src/sfizz/Synth.cpp @@ -459,8 +459,10 @@ void sfz::Synth::setSamplesPerBlock(int samplesPerBlock) noexcept this->tempMixNodeBuffer.resize(samplesPerBlock); for (auto& voice : voices) voice->setSamplesPerBlock(samplesPerBlock); - for (auto& bus : effectBuses) - bus->setSamplesPerBlock(samplesPerBlock); + for (size_t i = 0, n = effectBuses.size(); i < n; ++i) { + if (EffectBus* bus = effectBuses[i].get()) + bus->setSamplesPerBlock(samplesPerBlock); + } } void sfz::Synth::setSampleRate(float sampleRate) noexcept