sam/sfizz
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Removed usage of string-view literals

Browse source
This commit is contained in:
paulfd 2019-09-20 23:32:22 +02:00
parent 098bf5231d
commit 5250756fd1
1 changed files with 15 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
tests/HelpersT.cpp
View file

@ -23,36 +23,35 @@
#include "StringViewHelpers.h" #include "StringViewHelpers.h"
#include "catch2/catch.hpp" #include "catch2/catch.hpp"
#include <string_view> #include "absl/strings/string_view.h"
using namespace Catch::literals; using namespace Catch::literals;
using namespace std::literals::string_view_literals;
TEST_CASE("[Helpers] trimInPlace") TEST_CASE("[Helpers] trimInPlace")
{ {
SECTION("Trim nothing") SECTION("Trim nothing")
{ {
auto input { "view"sv }; absl::string_view input { "view" };
trimInPlace(input); trimInPlace(input);
REQUIRE(input == "view"sv); REQUIRE(input == "view");
} }
SECTION("Trim spaces") SECTION("Trim spaces")
{ {
auto input { " view "sv }; absl::string_view input { " view " };
trimInPlace(input); trimInPlace(input);
REQUIRE(input == "view"sv); REQUIRE(input == "view");
} }
SECTION("Trim other chars") SECTION("Trim other chars")
{ {
auto input { " \tview \t"sv }; absl::string_view input { " \tview \t" };
trimInPlace(input); trimInPlace(input);
REQUIRE(input == "view"sv); REQUIRE(input == "view");
} }
SECTION("Empty view") SECTION("Empty view")
{ {
auto input { " "sv }; absl::string_view input { " " };
trimInPlace(input); trimInPlace(input);
REQUIRE(input.empty()); REQUIRE(input.empty());
} }
@ -62,25 +61,25 @@ TEST_CASE("[Helpers] trim")
{ {
SECTION("Trim nothing") SECTION("Trim nothing")
{ {
auto input { "view"sv }; absl::string_view input { "view" };
REQUIRE(trim(input) == "view"sv); REQUIRE(trim(input) == "view");
} }
SECTION("Trim spaces") SECTION("Trim spaces")
{ {
auto input { " view "sv }; absl::string_view input { " view " };
REQUIRE(trim(input) == "view"sv); REQUIRE(trim(input) == "view");
} }
SECTION("Trim other chars") SECTION("Trim other chars")
{ {
auto input { " \tview \t"sv }; absl::string_view input { " \tview \t" };
REQUIRE(trim(input) == "view"sv); REQUIRE(trim(input) == "view");
} }
SECTION("Empty view") SECTION("Empty view")
{ {
auto input { " "sv }; absl::string_view input { " " };
REQUIRE(trim(input).empty()); REQUIRE(trim(input).empty());
} }
} }