sam/sfizz
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use SFINAE to replace if constexpr

Browse source
This commit is contained in:
paulfd 2019-09-20 22:58:26 +02:00
parent b80c5e5e9f
commit ce5b1981ea
1 changed files with 11 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
sfizz/Opcode.h
View file

@ -29,6 +29,7 @@
#include "StringViewHelpers.h" #include "StringViewHelpers.h"
#include <absl/types/optional.h> #include <absl/types/optional.h>
#include <string_view> #include <string_view>
#include <type_traits>
// charconv support is still sketchy with clang/gcc so we use abseil's numbers // charconv support is still sketchy with clang/gcc so we use abseil's numbers
#include "absl/strings/numbers.h" #include "absl/strings/numbers.h"
@ -44,10 +45,9 @@ struct Opcode {
LEAK_DETECTOR(Opcode); LEAK_DETECTOR(Opcode);
}; };
template <class ValueType> template <typename ValueType, std::enable_if_t<std::is_integral<ValueType>::value, int> = 0>
inline absl::optional<ValueType> readOpcode(absl::string_view value, const Range<ValueType>& validRange) inline absl::optional<ValueType> readOpcode(absl::string_view value, const Range<ValueType>& validRange)
{ {
if constexpr (std::is_integral<ValueType>::value) {
int64_t returnedValue; int64_t returnedValue;
if (!absl::SimpleAtoi(value, &returnedValue)) { if (!absl::SimpleAtoi(value, &returnedValue)) {
float floatValue; float floatValue;
@ -62,13 +62,16 @@ inline absl::optional<ValueType> readOpcode(absl::string_view value, const Range
returnedValue = std::numeric_limits<ValueType>::min(); returnedValue = std::numeric_limits<ValueType>::min();
return validRange.clamp(static_cast<ValueType>(returnedValue)); return validRange.clamp(static_cast<ValueType>(returnedValue));
} else { }
float returnedValue;
if (!absl::SimpleAtof(value, &returnedValue))
return absl::nullopt;
return validRange.clamp(returnedValue); template <typename ValueType, std::enable_if_t<std::is_floating_point<ValueType>::value, int> = 0>
} inline absl::optional<ValueType> readOpcode(absl::string_view value, const Range<ValueType>& validRange)
{
float returnedValue;
if (!absl::SimpleAtof(value, &returnedValue))
return absl::nullopt;
return validRange.clamp(returnedValue);
} }
inline absl::optional<bool> readBooleanFromOpcode(const Opcode& opcode) inline absl::optional<bool> readBooleanFromOpcode(const Opcode& opcode)