sam/sfizz
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #235 from jpcima/off-by

Browse source 
Off by
This commit is contained in:
JP Cimalando 2020-06-11 13:04:54 +02:00 • committed by GitHub
commit d9e49f7dc5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/sfizz/Region.cpp
View file

@ -138,7 +138,10 @@ bool sfz::Region::parseOpcode(const Opcode& rawOpcode)
setValueFromOpcode(opcode, group, Default::groupRange); setValueFromOpcode(opcode, group, Default::groupRange);
break; break;
case hash("off_by"): // also offby case hash("off_by"): // also offby
setValueFromOpcode(opcode, offBy, Default::groupRange); if (opcode.value == "-1")
offBy.reset();
else
setValueFromOpcode(opcode, offBy, Default::groupRange);
break; break;
case hash("off_mode"): // also offmode case hash("off_mode"): // also offmode
switch (hash(opcode.value)) { switch (hash(opcode.value)) {

3
tests/RegionT.cpp
View file

@ -180,8 +180,7 @@ TEST_CASE("[Region] Parsing opcodes")
REQUIRE(region.offBy); REQUIRE(region.offBy);
REQUIRE(*region.offBy == 5); REQUIRE(*region.offBy == 5);
region.parseOpcode({ "off_by", "-1" }); region.parseOpcode({ "off_by", "-1" });
REQUIRE(region.offBy); REQUIRE(!region.offBy);
REQUIRE(*region.offBy == 0);
} }
SECTION("off_mode") SECTION("off_mode")