diff --git a/src/sfizz/parser/Parser.cpp b/src/sfizz/parser/Parser.cpp index c846e588..071bc1e2 100644 --- a/src/sfizz/parser/Parser.cpp +++ b/src/sfizz/parser/Parser.cpp @@ -314,7 +314,7 @@ void Parser::processOpcode() // if sequence of identifier chars and then "=", an opcode follows else if (isIdentifierChar(valueRaw[i])) { ++i; - while (i < valueSize && isIdentifierChar(valueRaw[i])) + while (i < valueSize && (isIdentifierChar(valueRaw[i]) || valueRaw[i] == '$')) ++i; if (i < valueSize && valueRaw[i] == '=') stop = true; diff --git a/tests/ParsingT.cpp b/tests/ParsingT.cpp index 4cf3bbfa..a1e12266 100644 --- a/tests/ParsingT.cpp +++ b/tests/ParsingT.cpp @@ -622,6 +622,48 @@ R"(#define $B foo-$A-baz REQUIRE(mock.fullBlockMembers == expectedMembers); } +TEST_CASE("[Parsing] Strange #define behavior") +{ + sfz::Parser parser; + ParsingMocker mock; + parser.setListener(&mock); + parser.parseString("/define_cc_bug.sfz",R"( +#define $CCVAL 100 + amplitude_oncc$CCVAL=100 sample=*sine + transpose=-12 amplitude_oncc$CCVAL=100 sample=*sine + transpose=-12 amplitude_oncc100=100 sample=*sine +)"); + + std::vector> expectedMembers = { + {{"amplitude_oncc100", "100"}, + {"sample", "*sine"}}, + {{"transpose", "-12"}, + {"amplitude_oncc100", "100"}, + {"sample", "*sine"}}, + {{"transpose", "-12"}, + {"amplitude_oncc100", "100"}, + {"sample", "*sine"}}, + }; + + std::vector expectedHeaders = { + "region", "region", "region" + }; + std::vector expectedOpcodes; + + for (auto& members: expectedMembers) + for (auto& opcode: members) + expectedOpcodes.push_back(opcode); + + REQUIRE(mock.beginnings == 1); + REQUIRE(mock.endings == 1); + REQUIRE(mock.errors.empty()); + REQUIRE(mock.warnings.empty()); + REQUIRE(mock.opcodes == expectedOpcodes); + REQUIRE(mock.headers == expectedHeaders); + REQUIRE(mock.fullBlockHeaders == expectedHeaders); + REQUIRE(mock.fullBlockMembers == expectedMembers); +} + TEST_CASE("[Parsing] Opcode value special character") { sfz::Parser parser;